-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p11-kit: Expose version information through macros #635
Conversation
88be5ef
to
9eaea8f
Compare
d33f2bc
to
42cf1f4
Compare
This provides P11_KIT_VERSION_{MAJOR,MINOR,MICRO} from the <p11-kit/version.h> header, along with a helper macro P11_KIT_CHECK_VERSION(major, minor, micro) for checking the version requirement with `#if` directive. Signed-off-by: Daiki Ueno <[email protected]>
42cf1f4
to
fda7039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the review! |
Why is Given that p11 seems to require non-static builds, it seems like being able to verify that the (unavoidable)
|
I actually thought that run-time detection was already possible through PKCS#11 API (because |
This provides P11_KIT_VERSION_{MAJOR,MINOR,MICRO} from the <p11-kit/version.h> header, along with a helper macro P11_KIT_CHECK_VERSION(major, minor, micro) for checking the version requirement with
#if
directive.Fixes: #523