Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iter: Fix recursive attribute loading #642

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

heftig
Copy link
Contributor

@heftig heftig commented Jul 2, 2024

Fixes: #641

Fixes: p11-glue#641
Signed-off-by: Jan Alexander Steffens (heftig) <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 69.54% (+0.003%) from 69.537%
when pulling ce2e516 on heftig:recursive-fix
into d9449ee on p11-glue:master.

@ZoltanFridrich
Copy link
Contributor

Thank you for the MR. I will test it on fedora before merging.

@ZoltanFridrich
Copy link
Contributor

Looking at the code I cannot figure out why I chose to check the attr instead of templ + i. Seems like a mistake, however its weird that it didn't fail on x86_64 as well. I can confirm that the patch fixed the issue. Thank you!

@ZoltanFridrich ZoltanFridrich added this to the 0.25.5 milestone Jul 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 69.533% (-0.03%) from 69.562%
when pulling 714b9e7 on heftig:recursive-fix
into 694d5cb on p11-glue:master.

@ZoltanFridrich ZoltanFridrich merged commit fc0ed91 into p11-glue:master Jul 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure on 32-bit
3 participants