Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close hdf5 files, use hdfpy 3.12 #28

Merged
merged 2 commits into from
Sep 27, 2024
Merged

close hdf5 files, use hdfpy 3.12 #28

merged 2 commits into from
Sep 27, 2024

Conversation

sneakers-the-rat
Copy link
Collaborator

@sneakers-the-rat sneakers-the-rat commented Sep 27, 2024

There wasn't actually a bug in h5py 3.12, hdf5 just started enforcing consistent behavior on locking the same file when it's open in multiple places, as explained here:
h5py/h5py#2506

u live and u learn

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11063851845

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.757%

Totals Coverage Status
Change from base Build 11043742688: 0.0%
Covered Lines: 1192
Relevant Lines: 1207

💛 - Coveralls

@sneakers-the-rat sneakers-the-rat marked this pull request as ready for review September 27, 2024 03:11
@sneakers-the-rat sneakers-the-rat merged commit 69dbe39 into main Sep 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants