Skip to content

Commit

Permalink
Change the pin function id for uart3 (#37)
Browse files Browse the repository at this point in the history
  • Loading branch information
0r31 authored Jun 23, 2020
1 parent 9cb19ed commit 1d83743
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cores/arduino/HardwareSerial.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ class HardwareSerial : public Stream {
PinCfg.Pinnum = 11;
PINSEL_ConfigPin(&PinCfg);
} else if (UARTx == LPC_UART3) {
// Initialize UART2 pin connect
PinCfg.Funcnum = 1;
// Initialize UART3 pin connect
PinCfg.Funcnum = 2;
PinCfg.OpenDrain = 0;
PinCfg.Pinmode = 0;
PinCfg.Pinnum = 0;
Expand Down

1 comment on commit 1d83743

@ruedli
Copy link
Contributor

@ruedli ruedli commented on 1d83743 Aug 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just stumbled upon this while searching for info, but shouldn't it be the last function? So Funcnum = 3 ? Found this for the LPC1769, used in the BTT SKR 1.4 Turbo board. It uses pins 28 and 29 of port 4.

image

So I will try for the BTT SKR 1.4 Turbo board:

  // Initialize UART3 pin connect
  PinCfg.Funcnum =  3;
  PinCfg.OpenDrain = 0;
  PinCfg.Pinmode = 0;
  PinCfg.Pinnum = 28;
  PinCfg.Portnum = 4;
  PINSEL_ConfigPin(&PinCfg);
  PinCfg.Pinnum = 29;
  PINSEL_ConfigPin(&PinCfg);

Please sign in to comment.