Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abseil formatters #4971

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add abseil formatters #4971

wants to merge 5 commits into from

Commits on Nov 1, 2024

  1. Add abseil formatters for: 

      - cstring
  - IR::Node
  - IR::ID

This improves the code itself as we no longer need to do explicit
.toString() / .string_view() calls. Also, this prints directly to
sink, providing some performance improvements.

Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6ad6d74 View commit details
    Browse the repository at this point in the history

  2. Ensure that conversion from cstring to char* is explicit 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    82bf650 View commit details
    Browse the repository at this point in the history

  3. Update control-plane as now conversion cstring => string_view is not … 

    …ambiguous

Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d40822b View commit details
    Browse the repository at this point in the history

  4. Remove more instances of .string_view() calls 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6ff7a30 View commit details
    Browse the repository at this point in the history

  5. Fix some obvious Tofino cstring misuse 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    62781fb View commit details
    Browse the repository at this point in the history