Fix warning about delete not matching new #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asl
reviewed
Oct 31, 2024
| @@ -75,6 +75,7 @@ class Type_Any : Type, ITypeVar { | |||
| protected: | |||
| #emit | |||
| void *operator new(size_t size) { return ::operator new(size); } | |||
There was a problem hiding this comment.
Why do we need new override for these nodes?
There was a problem hiding this comment.
It was done to make them protected rather than public, so that other code could not directly call new and had to call the appropriate get method instead.
There was a problem hiding this comment.
Ah, ok, I missed that get methods.
fruffy
added
the
core
fruffy
approved these changes
Oct 31, 2024
asl
approved these changes
Oct 31, 2024
ChrisDodd
force-pushed
the
cdodd-delwarn
branch
from
23d4fcd
to
a5577c6
Compare
Signed-off-by: Chris Dodd <[email protected]>
|
Looks like this broke sanitizers build |
Yup, the nightly failed: https://github.com/p4lang/p4c/actions/runs/11621767033/job/32366099914 |
|
GCC 10 does not enable sized deallocation by default. We need to make these |
|
We'd likely need to guard these with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New gcc versions (11+) give a slew of warnings about a mismatched operator delete being called from a new expression. This trivial change fixes those warnings.