Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client project test #12

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Apr 10, 2024

This PR fixes the new client project test by responding to recent evolution of ESLint:

  • limits package.devDependencies.eslint to ~8.52.0 because some of this config's rules are considered to be deprecated by 8.53.0 and above. A client project that does not enforce the absence of deprecated rules can drift higher, so package.peerDependencies.eslint has been left unchanged
  • changes the new client project test to use eslint@8, because eslint@9 by default looks for a 'Flat Config'. There is a converter which the test could be upgraded to use in future if our config doesn't itself become a flat config.

@danyalaytekin danyalaytekin added this to the 4.0.0 milestone Apr 10, 2024
@danyalaytekin danyalaytekin self-assigned this Apr 10, 2024
@danyalaytekin danyalaytekin changed the title [WIP, draft] Fix client project test and clarify support is eslint@^8 [WIP, draft] Fix client project test Apr 10, 2024
@danyalaytekin danyalaytekin changed the title [WIP, draft] Fix client project test Fix client project test Apr 10, 2024
@danyalaytekin danyalaytekin marked this pull request as ready for review April 10, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant