Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple integration tests from JSON file, undo error code change #150

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Decouple integration tests from JSON file, undo error code change #150

merged 4 commits into from
Nov 10, 2023

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Nov 9, 2023 •
edited
Loading

This PR:

  • undoes the error code change in assertTestAppIsRunning from Add publishing workflow; update workflow, dependencies, tasks, docs #147
  • tests that the service will stop pleasantly
  • decouples the integration tests' spinup test, and setup for other tests, from the transient JSON file config/test.json
    • spinup test port can also now be supplied separately using PORT_FOR_SPINUP_TEST

@danyalaytekin danyalaytekin added this to the 4.2 milestone Nov 9, 2023
@danyalaytekin danyalaytekin self-assigned this Nov 9, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review November 9, 2023 18:45
jpw
jpw approved these changes Nov 10, 2023
View reviewed changes
Copy link

@jpw jpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danyalaytekin danyalaytekin merged commit 3eabe7f into main Nov 10, 2023
3 checks passed
@danyalaytekin danyalaytekin deleted the improve-integration-test-erroring branch November 10, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpw jpw jpw approved these changes

Assignees

@danyalaytekin danyalaytekin

Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@danyalaytekin @jpw