Fix / Correctly report HEAD sha #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vladjerca
commented
Mar 27, 2020
vladjerca
commented
- correctly report the head sha for pull requests
- update the yml definition to correctly reflect the available arguments
- fix the default value for the debug parameter and create helper input getters to prevent future errors
- fix check for the default value of the debug parameter - decrease error rate by extracting common branching
|
@vladjerca Thanks a lot for this PR! The cleanup was overdue, and looks good. Has this been tested? |
|
I'm using my fork here visual-cortex/imgstry#59 But I would like to switch to the parent source code as soon as this gets approved / merged. |
|
@paambaati For future reference, I'd be happy to add more unit tests for the utility methods (eg: getOptionalArray, etc...) when I have spare time on my hands 👍 |
|
@vladjerca This is now live on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.