Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video / gif issue for lower bandwidth users #598

Closed
gregoryhammond opened this issue Apr 5, 2024 · 1 comment · Fixed by #636
Closed

Video / gif issue for lower bandwidth users #598

gregoryhammond opened this issue Apr 5, 2024 · 1 comment · Fixed by #636
Assignees

Comments

@gregoryhammond
Copy link

Describe the bug
If someone has lower bandwidth (or there is a bandwidth issue anywhere) and tries to play a video (or gif), it doesn't play, and you can scroll down to the next post where the player disappears. There's no indication that it's being loaded.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any toot with a video, I used @[email protected] as an example.
  2. Click on the video to play it.
  3. Try to wait for the video to play, in the meantime you may be able to scroll the rest of the post and when you move onto the next post, the video player disappears.

Expected behavior
Something to indicate that it's being loaded. And possibly the option to open with an external browser.

Screenshots or video
Video showing me trying this can be seen on YouTube with no audio.

Links
Particular post used as an example: https://mastodon.social/@moxxi/112219560443244540

Versions
Please include the version of Pachli and Android you are using, and the software version your server is using. Find this on the Pachli "About" screen.
Using Pachli version 2.4.0. Android version 13, SDK level 33. The server I'm on is using version 4.2.7.

Affirmation
I have checked other issues for this project (open and closed) and I cannot find one that matches the problem I am reporting.

@nikclayton
Copy link
Contributor

Thanks for the report, and for including the video and example posts, that's very helpful. This'll be fixed in the next release.

@nikclayton nikclayton self-assigned this Apr 18, 2024
nikclayton added a commit to nikclayton/pachli-android that referenced this issue Apr 18, 2024
Video attachments may have a preview image. If they do, try and show
that image (from the cache) before the video loads, so the user has
something to look at. If there's no preview image, or it fails to load
fall back to a black screen with a progress spinner as normal.

This also provides a smooth transition when playing the first video
attachment, and fixes pachli#598.
nikclayton added a commit to nikclayton/pachli-android that referenced this issue Apr 22, 2024
Previous code didn't trigger the transition from `ViewMediaActivity`
when playing a video until the video had loaded. If the connection
was slow or had other issues this resulted in the video "sticking"
in the timeline until it loaded.

Change this, and trigger the transition immediately.

Fixes pachli#598

While looking at this:

- Save the play/pause state of the video during a swipe, pause the
  video, and restore the state when the swipe is cancelled.
- Transition the entire video view, to improve the animated transition
  back to the activity.
- Remove the custom progress spinner, use the one provided by the
  player.
- Display the player controller via the layout XML instead of code
nikclayton added a commit that referenced this issue Apr 23, 2024
Previous code didn't trigger the transition from `ViewMediaActivity`
when playing a video until the video had loaded. If the connection was
slow or had other issues this resulted in the video "sticking" in the
timeline until it loaded.

Change this, and trigger the transition immediately.

Fixes #598

While looking at this:

- Save the play/pause state of the video during a swipe, pause the
video, and restore the state when the swipe is cancelled.
- Transition the entire video view, to improve the animated transition
back to the activity.
- Remove the custom progress spinner, use the one provided by the
player.
- Display the player controller via the layout XML instead of code
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants