feat: Show text counter on caption dialog, request focus #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous layout didn't enable the character counter for entered text, so it was difficult for the user to see how much they had used. Fix that. To get the layout to play nicely switch to a ConstraintLayout with a chain to split the dialog roughly 50/50 between the image and the caption views. While I'm here: - Remove the margins around the image, so it's clearer, and is more consistent with the "set focus" dialog. - Set focus on the description immediately, so the keyboard pops up. - Remove focusability from the image, since the user shouldn't be able to interact with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous layout didn't enable the character counter for entered text, so it was difficult for the user to see how much they had used.
Fix that. To get the layout to play nicely switch to a ConstraintLayout with a chain to split the dialog roughly 50/50 between the image and the caption views.
While I'm here: