fix: Allow filter expiration to be set to "indefinite" #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mastodon API uses an "empty" `expires_in` value for a filter to mean "Does not expire" (i.e., indefinite). This was modelled as a null. Which doesn't work, because Retrofit does not send name/value pairs in encoded forms if the value is null. Fix this by making the API type a `String?`, and explicitly using the empty string when indefinite expiry is used. This has to be converted back to an Int? in a few places. See mastodon/documentation#1216 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mastodon API uses an "empty"
expires_invalue for a filter to mean "Does not expire" (i.e., indefinite).This was modelled as a null. Which doesn't work, because Retrofit does not send name/value pairs in encoded forms if the value is null.
Fix this by making the API type a
String?, and explicitly using the empty string when indefinite expiry is used. This has to be converted back to an Int? in a few places.See mastodon/documentation#1216 (comment)