feat: Add option to save attachments to per-account folders #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code downloaded any attachments to the user's "Downloads" folder. If the user is logged in with several accounts these downloads will be mixed up together. Fix this by adding a new preference that allows the user to specify the downloads should be placed in a sub-folder per account, named after the account. To do this: - Add an interface for enums that can be used as preferences, with properties for the string resource to display and the value to store. - Add `EnumListPreference`, a `ListPreference` that allows the user to choose between different enum values. - Add a `DownloadLocation` enum and preference key so the user can choose the location. - Add a `core.domain` module, with a use case for downloading URLs that respect's the user's download preference. Use this use-case everywhere that files are currently downloaded. Fixes #938
6 tasks
|
Aahhh, wait!
As I had described in the request #938 (comment) I need to sort downloads by the senders' accounts, not by my own ones (I do only have one). Thanks so much. |
|
Oh, my bad. Third option coming up in #954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code downloaded any attachments to the user's "Downloads" folder. If the user is logged in with several accounts these downloads will be mixed up together.
Fix this by adding a new preference that allows the user to specify the downloads should be placed in a sub-folder per account, named after the account.
To do this:
EnumListPreference, aListPreferencethat allows the user to choose between different enum values.DownloadLocationenum and preference key so the user can choose the location.core.domainmodule, with a use case for downloading URLs that respect's the user's download preference. Use this use-case everywhere that files are currently downloaded.Fixes #938