Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not always add a trailing newline upon saving #353

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Mar 15, 2024

Fixes #348.

RELEASE NOTES BEGIN

A trailing newline is no longer added to spec files without one upon saving.

RELEASE NOTES END

Copy link
Contributor

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5c0dc2083e3345b891069858186ff180

✔️ pre-commit SUCCESS in 2m 16s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 12s
✔️ specfile-tests-pip-deps SUCCESS in 1m 07s

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nforro nforro added the mergeit Zuul, merge it! label Mar 15, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e815dd0fb810482caa7213d3f582487e

✔️ pre-commit SUCCESS in 2m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit deb5532 into main Mar 15, 2024
31 of 32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the trailing_newline branch March 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packit adds missing trailing newline to the end of the spec file
2 participants