Skip to content

Commit

Permalink
chore: address review feedback -set e -set u + dx docs
Browse files Browse the repository at this point in the history
  • Loading branch information
YOU54F committed May 12, 2023
1 parent 793e681 commit 8675e28
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ npm test
```


_notes_ - As a developer you need you download the FFI libraries prior to running `npm install` / `npm ci` as the libraries will be expected to be there, and you won't have any `node_modules` installed yet.
_notes_ - As a developer, you need to run `bash script/download-libs.sh` to download the FFI libraries prior to running `npm install` / `npm ci` as the libraries will be expected to be there, and you won't have any `node_modules` installed yet.

For end users, the `ffi` folder is populated, as part of the npm publishing step.
3 changes: 2 additions & 1 deletion script/ci/build-and-test.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash -eu
set -eu # This needs to be here for windows bash, which doesn't read the #! line above
set -e # This needs to be here for windows bash, which doesn't read the #! line above
set -u

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")"; pwd)" # Figure out where the script is running
. "$SCRIPT_DIR"/../lib/robust-bash.sh
Expand Down

0 comments on commit 8675e28

Please sign in to comment.