Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid $.header.<...> value for headers matching rule in V2. #882

Closed
skaggmannen opened this issue May 22, 2019 · 2 comments
Closed

Invalid $.header.<...> value for headers matching rule in V2. #882

skaggmannen opened this issue May 22, 2019 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@skaggmannen
Copy link

Hi,

I'm using au.com.dius:pact-jvm-consumer-junit_2.12:3.6.7 to generate V2 pact files. These files fails to be properly consumed by the pact-ruby-standalone provider (used by pact-go among others).

It seems like pact-ruby-standalone expects the header matching rules to have the format $.headers.<...>, but pact-jvm generates them like $.header.<...> (notice the missing s).

This has been mentioned in the following issue: pact-foundation/pact-net#184 (comment)

Any chance this might get fixed in an upcoming release? Currently we're forced to manually edit all pact files, which is not sustainable.

@skaggmannen
Copy link
Author

After looking at the pact specification I found the following:

The second element of the path is the http type that the matcher is applied to (e.g., $.body or $.header).

So it seems that pact-jvm is actually following the spec, and pact-ruby-standalone is not. I'll close this issue.

@uglyog uglyog reopened this Jun 1, 2019
@uglyog uglyog added the bug Indicates an unexpected problem or unintended behavior label Jun 1, 2019
@uglyog
Copy link
Member

uglyog commented Jun 15, 2019

Version 3.6.8 has been released with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants