Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused ansicolor dependency #135

Conversation

Benjaminpjacobs
Copy link
Contributor

The term-ansicolor gem injects a global Term module that has a high probability of naming collision for other common class names. This PR removes that gem from this repo as it is not used anywhere.

@bethesque
Copy link
Member

I don't think this is necessary - it will auto update anyway with a bundle update.

@Benjaminpjacobs
Copy link
Contributor Author

@bethesque this whole PR is unnecessary? My only concern is that if the gem is included, even if it's not referenced, it might still pollute the namespace.

@YOU54F
Copy link
Member

YOU54F commented May 11, 2023

I think we can remove gem.add_runtime_dependency 'term-ansicolor', '~> 1.0' as its not used like you point out, but we don't need to update the pact-mock-service to fix to the patch version, the minor version will mean it will pick up the latest, 1.19.

I've included this in #141 Thanks!

@YOU54F YOU54F merged commit f20db7b into pact-foundation:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants