fix(#468): Allow non-ASCII chars on most user input #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to marshal strings, which don't marshal nicely over the FFI boundary because C# uses UTF-16 but Rust wants UTF-8, instead explicitly convert strings to a UTF-8 `byte[]` and marshal those. Some places don't need to allow non-ASCII, such as the scheme in URLs, whereas others are very tricky, such as consumer filters. This would change the API to `byte[][]` and those can't be marshalled, so some parts still support non-ASCII for now. If that's a problem in the future then some custom marshalling could be implemented, but currently that seems overkill.
TDavtyan-ST
approved these changes
Jul 17, 2023
| @@ -71,6 +71,7 @@ public PactExtensionsTests(ITestOutputHelper output) | |||
| File.Delete("PactExtensionsTests-Consumer-V3-PactExtensionsTests-Provider.json"); | |||
| File.Delete("PactExtensionsTests-Consumer-V4-PactExtensionsTests-Provider.json"); | |||
| File.Delete("PactExtensionsTests-Combined-V4-PactExtensionsTests-Provider.json"); | |||
| File.Delete("PactExtensio�sTests-Combined-V4-PactExtensio�sTests-Provider.json"); | |||
There was a problem hiding this comment.
ñ - pretty unnoticable in Code Review :)
|
This is no longer compatible with PactNet 5.x and an alternative fix will be created instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to marshal strings, which don't marshal nicely over the FFI boundary because C# uses UTF-16 but Rust wants UTF-8, instead explicitly convert strings to a UTF-8
byte[]and marshal those.Some places don't need to allow non-ASCII, such as the scheme in URLs, whereas others are very tricky, such as consumer filters. This would change the API to
byte[][]and those can't be marshalled, so some parts still support non-ASCII for now. If that's a problem in the future then some custom marshalling could be implemented, but currently that seems overkill.Closes #468