Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow like null #350

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Allow like null #350

merged 2 commits into from
Oct 27, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Oct 27, 2023

The condition $value !== null probably related to Ruby core. I tested with null value and it works fine. So I remove this condition.

Depend on #349, please review it first

@tienvx
Copy link
Contributor Author

tienvx commented Oct 27, 2023

I will merge this PR now since it has been approved.

@tienvx tienvx merged commit 67e9f20 into pact-foundation:ffi Oct 27, 2023
26 checks passed
@tienvx tienvx deleted the allow-like-null branch October 27, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @YOU54F