refactor: Add EachValue matcher class #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienvx
force-pushed
the
add-each-value-matcher-class
branch
from
37f517b
to
4f93b05
Compare
Lewiscowles1986
approved these changes
Dec 17, 2023
|
Thanks you. I'm appreciated your reviewing. More PRs are coming. And they are going to be bigger and uglier, especially the compatibility suites stuff. I will try to make them small. The holiday is approaching, so you don't have to review them right now. Please enjoy your holiday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matcher is defined at https://github.com/pact-foundation/pact-specification/tree/version-4#supported-matching-rules
Depend on #414