Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add PluginFormatter #448

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Jan 16, 2024

@Lewiscowles1986
Copy link
Collaborator

So one concern with these works, is that anyone using your work, might see backwards compatibility breaks. I Don't think this should be blocked entirely, but I do know that at some point, you'll want a stable interface for pact users and plugin authors alike.

Do you have some form of view around the time-frame, and might it be advantageous to use some form of phpDoc comment to annotate?

@tienvx
Copy link
Contributor Author

tienvx commented Jan 17, 2024

anyone using your work, might see backwards compatibility breaks

Yes, I'm aware about this. Given that there is only 1 download on average each month for all alpha releases of version 10 according to packagist, and the interface FormatterInterface is not introduced in any alpha releases yet, I think it's fine.

at some point, you'll want a stable interface for pact users and plugin authors alike.

yes, it might be in beta phrase. For now I would like to change it when it's needed.

Do you have some form of view around the time-frame, and might it be advantageous to use some form of phpDoc comment to annotate?

Can you rephrase this question for me.

@tienvx
Copy link
Contributor Author

tienvx commented Jan 23, 2024

A remind for @Lewiscowles1986

@Lewiscowles1986
Copy link
Collaborator

Ah, I'd missed the reply here.

RE:

Do you have some form of view around the time-frame, and might it be advantageous to use some form of phpDoc comment to annotate?

Can you rephrase this question for me.

Do you know how long it will take for this to come out of alpha?

Really as you've quantified one user impact, it should not matter anyway.

@tienvx
Copy link
Contributor Author

tienvx commented Jan 23, 2024

Do you know how long it will take for this to come out of alpha?

I have some items in my mind for the next 2 or 3 more alpha versions:

  • Refactor code related to InteractionBuilder/MessageBuilder if needed
  • Add unit tests as much as possible
  • Update document/readme

Probably it will take 1 or 2 months

@tienvx tienvx merged commit 61b4f69 into pact-foundation:ffi Jan 23, 2024
24 of 30 checks passed
@tienvx tienvx deleted the plugin-formatter branch January 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants