Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compatibility-suite): Fix compatibility suite v1 hang #463

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Feb 6, 2024

I think recent update to pact broker 2.115 or 2.116 cause pact broker to hang. Move to 2.114 a month ago solve the issue

@YOU54F
Copy link
Member

YOU54F commented Feb 6, 2024

hmmm, I'd like to know what caused that, as I've put out a couple of releases and everything has been green. will do some sleuthing

@YOU54F
Copy link
Member

YOU54F commented Feb 6, 2024

So it is an issue that was affecting aarch64 images with sqlite since we initially built them, but is affecting x86_64 images too, since we updated the alpine image to 3.19.

tracking issue pact-foundation/pact-broker-docker#148

@YOU54F
Copy link
Member

YOU54F commented Feb 6, 2024

thanks for the heads up @tienvx

@YOU54F
Copy link
Member

YOU54F commented Feb 6, 2024

Fix for sqlite in pact-broker has been merged and will be released shortly

pact-foundation/pact-broker-docker#166

@YOU54F
Copy link
Member

YOU54F commented Feb 6, 2024

Released and all sorted, have re-ran the failing jobs and they are all passing now. We will want to get some tests in pact-broker that utilise sqlite as part of the test run (it currently just runs against pg for integration tests)

@tienvx
Copy link
Contributor Author

tienvx commented Feb 7, 2024

Look like it's fixed in 2.117. So we can close this PR. It's no longer needed. Thank @YOU54F for fixing.

@tienvx tienvx closed this Feb 7, 2024
@tienvx tienvx deleted the fix-compatibility-suite-v1-hang branch February 7, 2024 04:02
@tienvx
Copy link
Contributor Author

tienvx commented Mar 5, 2024

Look like it happen again on 2.118

@tienvx tienvx restored the fix-compatibility-suite-v1-hang branch March 5, 2024 05:59
@tienvx tienvx reopened this Mar 5, 2024
@tienvx tienvx force-pushed the fix-compatibility-suite-v1-hang branch from bfd4950 to 64a699d Compare March 5, 2024 06:11
@tienvx tienvx merged commit 72494b5 into pact-foundation:ffi Mar 5, 2024
25 checks passed
@tienvx tienvx deleted the fix-compatibility-suite-v1-hang branch March 5, 2024 06:38
@tienvx
Copy link
Contributor Author

tienvx commented Mar 5, 2024

Reopened, updated to 2.117 and merged

@YOU54F
Copy link
Member

YOU54F commented Mar 5, 2024

thanks Tien, sorry the latest image has gone out with a bug, am sorting it ( reverting a pr ) and will get it out shortly

@YOU54F
Copy link
Member

YOU54F commented Mar 5, 2024

@tienvx there is a new release now so this should be solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants