Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused exception ConnectionException #478

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Feb 16, 2024

The exception ConnectionException is for version <=9 when user work with mock server directly.
At version 10, mock server is automatically started and stopped, so this exception is no longer needed

@Lewiscowles1986
Copy link
Collaborator

Approved, but logically, this speaks to a degredation in code quality as we can't discern specific classes of errors.

@tienvx
Copy link
Contributor Author

tienvx commented Feb 17, 2024

At version 10, mock server is automatically started and stopped, so this exception is no longer needed

I was wrong about this. I mean:

At version 10, user doesn't work with mock server directly, so this exception is no longer needed

@tienvx tienvx merged commit f8f82b8 into pact-foundation:ffi Feb 17, 2024
30 checks passed
@tienvx tienvx deleted the remove-unused-exception branch February 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants