Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test Verifier #516

Merged
merged 1 commit into from
Mar 7, 2024
Merged

test: Test Verifier #516

merged 1 commit into from
Mar 7, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Mar 6, 2024

  • Remove return $this
  • Use mocks in VerifierTest

@Lewiscowles1986
Copy link
Collaborator

This is quite the change to usage to go from self to void, especially with a builder pattern.

@tienvx
Copy link
Contributor Author

tienvx commented Mar 7, 2024 •
edited
Loading

They are all private methods. They are not belong to builder pattern. They can be called in any order (except newHandle need to be called first to get the handle of course).

Other public methods (addFile, addDirectory, addUrl, addBroker, verify) are not changed.

@tienvx tienvx merged commit 7dad9bb into pact-foundation:ffi Mar 7, 2024
25 checks passed
@tienvx tienvx deleted the test-verifier branch March 7, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @Lewiscowles1986