Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix wrong type #578

Merged
merged 2 commits into from
Apr 26, 2024
Merged

chore: Fix wrong type #578

merged 2 commits into from
Apr 26, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Apr 26, 2024

Fix this error:

  40     Parameter #1 $status of method                                        
         PhpPact\Consumer\Model\ProviderResponse::setStatus() expects          
         int|PhpPact\Consumer\Matcher\Model\MatcherInterface, string given.

For #564

@tienvx tienvx requested a review from JP-Ellis April 26, 2024 03:45
@tienvx tienvx marked this pull request as draft April 26, 2024 03:48
@tienvx tienvx marked this pull request as ready for review April 26, 2024 06:00
@tienvx tienvx merged commit 214bf03 into pact-foundation:master Apr 26, 2024
26 checks passed
@tienvx tienvx deleted the fix-wrong-type branch April 26, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @JP-Ellis