Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Refactor readme using structure from pact-js #604

Merged
merged 1 commit into from
May 13, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented May 12, 2024

  • Use structure from pact-js/pact-go
  • There are no workshop for pact-php, so I remove that section
  • Change version of platform windows x86 from All to 9.x - docs: platform support #600

@tienvx
Copy link
Contributor Author

tienvx commented May 13, 2024

Self-reviewed

@tienvx tienvx merged commit 9dfeafc into pact-foundation:master May 13, 2024
26 checks passed
@tienvx tienvx deleted the refactor-readme branch May 13, 2024 01:25
@mefellows
Copy link
Member

Looks great Tien! 👏

Couple of minor comments - this needs a link:

Screenshot 2024-05-13 at 2 59 16 PM

Could format as code (minor):

Screenshot 2024-05-13 at 3 00 45 PM

Missing plugin documentation?

@tienvx
Copy link
Contributor Author

tienvx commented May 13, 2024

  • I fixed the link to installation.
  • I created ticket for code formatting docs: Code block is not formatted #609
  • Missing plugin documentation?
    • Yes. Currently I only move the existing document from readme to other pages. I didn't spend much time on reading document from other projects and make pact-php follow deeper structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants