refactor: Merge formatters into matchers #677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
SOLID
L - Liskov Substitution Principle
Currently most of formatter's code are like this:
Now it's just a method inside matcher:
I - Interface Segregation Principle
Create bunch of small interfaces. Matchers can decide to implement interface that it need:
no need to implement a big interface then throw exception on unused method like before:
O - Open-Closed Principle
Instead of using
array
andstring
, wrap them in new classesAttributes
andExpression
Simplify generator flow
Old flow
New flow
Breaking changes
I tried not to introduce any breaking changes. All matchers can be used normally using the helper class
Matcher