feat: publish provider contracts using all in one endpoint #141
Conversation
| "_links": { | ||
| "self": [ | ||
| { | ||
| "href": "http://example.org/pacts/provider/Pricing%20Service/consumer/Condor/latest" |
There was a problem hiding this comment.
Good Ol' Condor and the Pricing Service
There was a problem hiding this comment.
They'll always live on in our test data.
| end | ||
| end | ||
| def enabled? | ||
| ENV.fetch("PACT_BROKER_FEATURES", "").include?("publish_provider_contracts_all_in_one") |
There was a problem hiding this comment.
Would the user set this?
will it say be set in the pact-cli and pact-ruby-standalone packages for the pactflow command, or are we expecting this to be used in testing for a bit and then we use the all in one?
There was a problem hiding this comment.
why is the old way of publishing hanging around, whats the craic in general. is that meant to be phased out over time
There was a problem hiding this comment.
The feature toggle is so we can use it internally for a few days before putting it out for public use. It's what I do for all our new commands. The code will be included in the docker images and ruby standalone as soon as I release it (today).
The old way is required because this is a brand new API, and our onprem customers will be using previous versions of Pactflow for who-knows-how-long. Some only update once a year or so.
There was a problem hiding this comment.
Ok fabulous, that sounds like a really well considered approach, thanks for clarifying @bethesque
|
|
||
| def initialize(params, options, pact_broker_client_options) | ||
| super | ||
| @provider_name = params[:provider_name] | ||
| @provider_version_number = params[:provider_version_number] | ||
| @branch_name = params[:branch_name] | ||
| @tags = params[:tags] || [] | ||
| @build_url = params[:build_url] |
|
Awesome looks great to me. Just a reminder to me to update docs here https://docs.pactflow.io/docs/bi-directional-contract-testing/publishing/ to include the build_url param |
|
Thanks for the reminder. I forget that things are sprinkled around different parts of the docs now. |
bethesque
deleted the
feat/publish-provider-contracts-using-all-in-one-endpoint
branch
No description provided.