fix: no block request message in hello-ack phase

sync/handler_hello_ack.go

@@ -33,8 +33,6 @@ func (handler *helloAckHandler) ParseMessage(m message.Message, initiator peer.I
 	handler.logger.Debug("hello message acknowledged",
 		"from", initiator.ShortString())
 
-	handler.updateBlockchain()
-
 	return nil
 }
 

sync/handler_hello_ack_test.go

@@ -5,30 +5,26 @@ import (
 
 	"github.com/pactus-project/pactus/sync/bundle/message"
 	"github.com/pactus-project/pactus/sync/peerset"
-	"github.com/pactus-project/pactus/sync/services"
 	"github.com/stretchr/testify/assert"
 )
 
 func TestParsingHelloAckMessages(t *testing.T) {
 	td := setup(t, nil)
 
-	t.Run("Receiving HelloAck message: Rejected hello",
+	t.Run("Receiving HelloAck message: Rejected",
 		func(t *testing.T) {
 			pid := td.RandPeerID()
 			msg := message.NewHelloAckMessage(message.ResponseCodeRejected, "rejected")
 
 			assert.NoError(t, td.receivingNewMessage(td.sync, msg, pid))
 		})
 
-	t.Run("Receiving HelloAck message: OK hello",
+	t.Run("Receiving HelloAck message: OK",
 		func(t *testing.T) {
 			pid := td.RandPeerID()
-			pub, _ := td.RandBLSKeyPair()
-			td.addPeer(t, pub, pid, services.New(services.Network))
 			msg := message.NewHelloAckMessage(message.ResponseCodeOK, "ok")
 
 			assert.NoError(t, td.receivingNewMessage(td.sync, msg, pid))
 			td.checkPeerStatus(t, pid, peerset.StatusCodeKnown)
-			shouldPublishMessageWithThisType(t, td.network, message.TypeBlocksRequest)
 		})
 }