fix(cmd): add pprof as default in http server (#1511)

cmd/daemon/start.go

@@ -1,11 +1,8 @@
 package main
 
 import (
-	"net/http"
-	_ "net/http/pprof" // #nosec
 	"os"
 	"path/filepath"
-	"time"
 
 	"github.com/gofrs/flock"
 	"github.com/pactus-project/pactus/cmd"
@@ -27,9 +24,6 @@ func buildStartCmd(parentCmd *cobra.Command) {
 	passwordOpt := startCmd.Flags().StringP("password", "p", "",
 		"the wallet password")
 
-	pprofOpt := startCmd.Flags().String("pprof", "",
-		"pprof server address (for debugging)")
-
 	startCmd.Run = func(_ *cobra.Command, _ []string) {
 		workingDir, _ := filepath.Abs(*workingDirOpt)
 		// change working directory
@@ -49,18 +43,6 @@ func buildStartCmd(parentCmd *cobra.Command) {
 			return
 		}
 
-		if *pprofOpt != "" {
-			cmd.PrintWarnMsgf("Starting Debug pprof server on: http://%s/debug/pprof/", *pprofOpt)
-			server := &http.Server{
-				Addr:              *pprofOpt,
-				ReadHeaderTimeout: 3 * time.Second,
-			}
-			go func() {
-				err := server.ListenAndServe()
-				cmd.FatalErrorCheck(err)
-			}()
-		}
-
 		passwordFetcher := func(wlt *wallet.Wallet) (string, bool) {
 			if !wlt.IsEncrypted() {
 				return "", true

www/http/server.go

@@ -3,10 +3,12 @@ package http
 import (
 	"bytes"
 	"context"
+	"expvar"
 	"fmt"
 	"io"
 	"net"
 	"net/http"
+	"net/http/pprof"
 	"strings"
 	"time"
 
@@ -85,6 +87,8 @@ func (s *Server) StartServer(grpcServer string) error {
 	s.router.HandleFunc("/validator/address/{address}", s.GetValidatorHandler)
 	s.router.HandleFunc("/validator/number/{number}", s.GetValidatorByNumberHandler)
 	s.router.HandleFunc("/metrics/prometheus", promhttp.Handler().ServeHTTP)
+	s.router.HandleFunc("/debug/pprof/", pprof.Index)
+	s.router.Handle("/debug/vars", expvar.Handler())
 
 	if s.enableAuth {
 		http.Handle("/", handlers.RecoveryHandler()(basicAuth(s.router)))