Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger API suggestion #932

Closed
b00f opened this issue Jan 11, 2024 · 0 comments · Fixed by #935
Closed

Swagger API suggestion #932

b00f opened this issue Jan 11, 2024 · 0 comments · Fixed by #935
Labels
good first issue Good for newcomers help wanted Extra attention is needed www

Comments

@b00f
Copy link
Collaborator

b00f commented Jan 11, 2024

Here is the current APIs in our swagger:

image

I suggest to modify these API, like:

  • Rename /v1/transactions/send/{data} to /v1/transactions/broadcast/{raw_data} for better clarity
  • For Get Raw Data API add a path for type of transaction, like: /v1/transactions/transfer/..., /v1/transactions/bond/...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed www
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(gRPC): defining transaction APIs properly kehiy/pactus
1 participant
@b00f