Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gRPC): defining transaction APIs properly #935

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jan 11, 2024

Description

We should make sure using signed_tx is the best option. that's better to discuss differences between raw transactions, signed transactions, and ...

Related issue(s)

@kehiy kehiy requested a review from b00f January 11, 2024 10:39
@kehiy kehiy self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Merging #935 (ab324d6) into main (93570b0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   83.42%   83.38%   -0.05%     
==========================================
  Files         171      171              
  Lines        8828     8828              
==========================================
- Hits         7365     7361       -4     
- Misses       1108     1112       +4     
  Partials      355      355              

@b00f b00f changed the title chore: defining transaction APIs properly chore(gRPC): defining transaction APIs properly Jan 11, 2024
@b00f
Copy link
Collaborator

b00f commented Jan 11, 2024

Please merge after releasing the version 0.20.0

@kehiy @amirvalhalla

@amirvalhalla
Copy link
Member

@kehiy
I'll merge It after release finished

@amirvalhalla amirvalhalla merged commit 3f36b3e into pactus-project:main Jan 11, 2024
12 checks passed
@kehiy kehiy deleted the hotfix/rpcs branch January 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger API suggestion
3 participants