feat(grpc): calculate fee for create-raw-transaction APIs #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
- Coverage 81.40% 81.30% -0.10%
==========================================
Files 173 173
Lines 9245 9272 +27
==========================================
+ Hits 7526 7539 +13
- Misses 1364 1373 +9
- Partials 355 360 +5 |
b00f
force-pushed
the
grpc-calc-fee-on-create-tx
branch
from
6a45e82
to
7ab897d
Compare
amirvalhalla
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR calculates the fee based on the amount if it is not set (or set to zero).
It also sets the lock-time to the latest block height if it is not set (or set to zero).