refactor: using PAC instead of atomic units for external input/outputs #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
- Coverage 80.81% 80.70% -0.11%
==========================================
Files 177 177
Lines 9413 9417 +4
==========================================
- Hits 7607 7600 -7
- Misses 1435 1443 +8
- Partials 371 374 +3 |
b00f
reviewed
Mar 11, 2024
b00f
reviewed
Mar 11, 2024
kehiy
reviewed
Mar 11, 2024
kehiy
changed the title
b00f
reviewed
Mar 11, 2024
b00f
reviewed
Mar 11, 2024
b00f
reviewed
Mar 11, 2024
b00f
requested changes
Mar 12, 2024
b00f
approved these changes
Mar 13, 2024
| @@ -145,10 +145,10 @@ message GetRawWithdrawTransactionRequest { | |||
| string account_address = 3; | |||
| // Withdrawal amount. | |||
| // It should be greater than 0. | |||
| int64 amount = 4; | |||
| double amount = 4; | |||
| // Transaction fee. | |||
There was a problem hiding this comment.
Suggested change
| // Transaction fee. | |
| // Transaction fee in PAC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
convert coin type for Proto requests to accept coin instead of coin unit