Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement basic auth for pactus shell #1177

Merged
merged 6 commits into from
Mar 23, 2024

Conversation

amirvalhalla
Copy link
Member

Description

implement basic auth for pactus shell

@amirvalhalla amirvalhalla requested a review from b00f March 22, 2024 14:33
@amirvalhalla amirvalhalla self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #1177 (32f8720) into main (4cc28b5) will decrease coverage by 0.06%.
The diff coverage is 23.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   80.81%   80.76%   -0.06%     
==========================================
  Files         178      179       +1     
  Lines        9457     9465       +8     
==========================================
+ Hits         7643     7644       +1     
- Misses       1440     1446       +6     
- Partials      374      375       +1     

cmd/shell/cmd/root.go Outdated Show resolved Hide resolved
cmd/shell/cmd/client.go Outdated Show resolved Hide resolved
cmd/shell/cmd/client.go Outdated Show resolved Hide resolved
cmd/shell/cmd/root.go Outdated Show resolved Hide resolved
cmd/shell/cmd/client.go Outdated Show resolved Hide resolved
cmd/shell/cmd/auth.go Outdated Show resolved Hide resolved
@amirvalhalla amirvalhalla requested a review from b00f March 22, 2024 16:22
cmd/shell/cmd/client.go Outdated Show resolved Hide resolved
util/auth.go Outdated Show resolved Hide resolved
cmd/shell/cmd/auth.go Outdated Show resolved Hide resolved
util/auth_test.go Outdated Show resolved Hide resolved
@amirvalhalla amirvalhalla requested a review from b00f March 23, 2024 14:27
@b00f
Copy link
Collaborator

b00f commented Mar 23, 2024

@amirvalhalla LGTM. Thanks. Just one comment to merge

@amirvalhalla
Copy link
Member Author

@amirvalhalla LGTM. Thanks. Just one comment to merge

done

cmd/shell/cmd/client.go Outdated Show resolved Hide resolved
cmd/shell/cmd/client.go Outdated Show resolved Hide resolved
www/grpc/basicauth/basicauth.go Show resolved Hide resolved
www/grpc/basicauth/credential.go Outdated Show resolved Hide resolved
@b00f b00f merged commit 3e0ec04 into pactus-project:main Mar 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants