Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): one reward address in config for all validators #1178

Merged
merged 11 commits into from
Mar 29, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Mar 23, 2024

Description

This PR checks if there is only one reward address in the config, it assigns it to all validators. Otherwise, the number of reward addresses should be the same as the number of validator addresses. If not, the reward addresses will be obtained from the wallet.

@b00f b00f changed the title Feat one reward address in config feat(config): one reward address in config for all validators Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Merging #1178 (1cce718) into main (3ba0150) will increase coverage by 0.50%.
The diff coverage is 59.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
+ Coverage   80.73%   81.23%   +0.50%     
==========================================
  Files         179      179              
  Lines        9467     9481      +14     
==========================================
+ Hits         7643     7702      +59     
+ Misses       1447     1392      -55     
- Partials      377      387      +10     

@b00f b00f force-pushed the feat-one-reward-address-in-config branch from 5ecea63 to d530d51 Compare March 23, 2024 18:52
@b00f b00f force-pushed the feat-one-reward-address-in-config branch from d530d51 to 084bad3 Compare March 23, 2024 18:54
@b00f b00f merged commit 20d5d83 into pactus-project:main Mar 29, 2024
11 of 12 checks passed
@b00f b00f deleted the feat-one-reward-address-in-config branch March 29, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants