Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed deprecated LockWallet and UnLockWallet from WalletService #1343

Conversation

ansh-devs
Copy link
Member

@ansh-devs ansh-devs commented Jun 13, 2024

Remove deprecated LockWallet and UnLockWallet methods from WalletService

Description

  • Deprecated Definition LockWallet & ``UnLockWallet are removed.
  • gRPC Implementation for LockWallet & ``UnLockWallet that were returning unimplemented status are removed.

Related issue(s)

@ansh-devs ansh-devs requested a review from b00f June 13, 2024 17:03
@ansh-devs ansh-devs changed the title (refactor): removed deprecated LockWallet and UnLockWallet from WalletService refactor: removed deprecated LockWallet and UnLockWallet from WalletService Jun 13, 2024
@ansh-devs ansh-devs self-assigned this Jun 13, 2024
@b00f
Copy link
Collaborator

b00f commented Jun 13, 2024

Thanks @ansh-devs

@b00f b00f merged commit 868a948 into pactus-project:main Jun 13, 2024
11 of 12 checks passed
@ansh-devs ansh-devs deleted the 1340-lockwallet-and-unlockwallet-are-deprecated branch June 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LockWallet and UnlockWallet are deprecated
2 participants