feat(firewall): check valid gossip and stream messages #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 77.16% 76.44% -0.73%
==========================================
Files 233 215 -18
Lines 11941 11066 -875
==========================================
- Hits 9214 8459 -755
+ Misses 2305 2214 -91
+ Partials 422 393 -29 |
Ja7ad
approved these changes
Jul 10, 2024
b00f
force-pushed
the
feat/check-gossip-message
branch
2 times, most recently
from
cf7c223
to
a45e4ad
Compare
b00f
force-pushed
the
feat/check-gossip-message
branch
from
a45e4ad
to
4f91ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a TODO to check if gossip messages are not sent directly and if stream messages are not broadcasted. If so, the message will be dropped and the peer will be banned.