Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): define full and prune service #1412

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jul 13, 2024

Description

This PR defines new services for the pruned node. The NodeNetwork service is now replaced by the FullNode service and is not configurable. This means that if a node is a full node, it provides both full and pruned services. If a node is a pruned node, it only provides the pruned service.

Related issue(s)

@Ja7ad Ja7ad added this to the v1.4.0 milestone Jul 13, 2024
@Ja7ad Ja7ad requested a review from kehiy July 13, 2024 11:13
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.98%. Comparing base (6318fad) to head (fa15259).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
+ Coverage   76.35%   76.98%   +0.63%     
==========================================
  Files         215      216       +1     
  Lines       11051    11108      +57     
==========================================
+ Hits         8438     8552     +114     
+ Misses       2219     2156      -63     
- Partials      394      400       +6     

@b00f b00f merged commit 89ba289 into pactus-project:main Jul 13, 2024
10 checks passed
@b00f b00f deleted the feat/sync-prun-service branch July 13, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable NodeNetwork flag on Prune mode
2 participants