Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(genesis): separating chain param from genesis param #1463

Merged
merged 3 commits into from
Aug 12, 2024
Merged

feat(genesis): separating chain param from genesis param #1463

merged 3 commits into from
Aug 12, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Aug 11, 2024

@kehiy kehiy added the Mainnet label Aug 11, 2024
@kehiy kehiy requested a review from b00f August 11, 2024 19:02
@codecov Codecov
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (dcdb8bf) to head (597f994).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
+ Coverage   75.20%   75.45%   +0.25%     
==========================================
  Files         223      226       +3     
  Lines       11654    11684      +30     
==========================================
+ Hits         8764     8816      +52     
+ Misses       2461     2443      -18     
+ Partials      429      425       -4

b00f
b00f reviewed Aug 12, 2024
View reviewed changes
tests/main_test.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f August 12, 2024 08:18
b00f
b00f reviewed Aug 12, 2024
View reviewed changes
state/state_test.go Outdated Show resolved Hide resolved
b00f
b00f reviewed Aug 12, 2024
View reviewed changes
tests/main_test.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f August 12, 2024 11:24
@b00f b00f merged commit 9991001 into pactus-project:main Aug 12, 2024
10 checks passed
@kehiy kehiy deleted the feature/chain-param branch August 12, 2024 11:42
@kehiy kehiy added this to the v1.4.1 milestone Aug 12, 2024
@kehiy kehiy restored the feature/chain-param branch August 12, 2024 14:06
@kehiy kehiy deleted the feature/chain-param branch August 12, 2024 14:06
@Ja7ad Ja7ad modified the milestones: v1.4.1, v.1.5.0 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees
No one assigned
Labels
Mainnet
Projects
None yet
Milestone
v.1.5.0
Development

Successfully merging this pull request may close these issues.

Set fee paramaetrs to zero in genesis doc
3 participants
@kehiy @b00f @Ja7ad