feat(gtk): support create Ed25519 in gtk #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you get password before generating the Ed25519? |
fixed |
b00f
reviewed
Aug 29, 2024
|
@Ja7ad please update the description |
b00f
reviewed
Aug 29, 2024
b00f
reviewed
Aug 29, 2024
b00f
requested changes
Sep 2, 2024
| @@ -21,13 +20,13 @@ func createAddress(ww *widgetWallet) { | |||
| addressLabel := getEntryObj(builder, "id_entry_account_label") | |||
|
|
|||
| addressTypeCombo := getComboBoxTextObj(builder, "id_combo_address_type") | |||
| addressTypeCombo.Append(wallet.AddressTypeBLSAccount, "Account") | |||
| addressTypeCombo.Append(wallet.AddressTypeEd25519Account, "ED25519 Account") | |||
There was a problem hiding this comment.
We can define String function for Address Types
There was a problem hiding this comment.
Address types in wallet is not enum and don't have specific type for define String method.
We can use crypto.AddressType in future.
b00f
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR support generation Ed25519 account type on GTK.
Related issue(s)