Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): replace bls12-381 kilic with gnark #1510

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Sep 28, 2024

Description

This PR replace BLS12-381 kilic with gnark. The benchmark:

BenchmarkVerify-8 (OLD)               1008       1227301 ns/op       67792 B/op         159 allocs/op
BenchmarkVerify-8 (NEW)               1279        992421 ns/op        6373 B/op          59 allocs/op

This PR will close #955

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (dcdb8bf) to head (59fdf7f).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   75.20%   74.96%   -0.24%     
==========================================
  Files         223      233      +10     
  Lines       11654    12112     +458     
==========================================
+ Hits         8764     9080     +316     
- Misses       2461     2590     +129     
- Partials      429      442      +13     

@Ja7ad Ja7ad requested a review from kehiy September 28, 2024 12:24
@b00f b00f merged commit 1a609e1 into pactus-project:main Sep 28, 2024
10 checks passed
@b00f b00f deleted the refactor/bls12-381-consensys branch September 28, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto Module
2 participants