fix(daemon): build android version on go v1.23.2 pactus-daemon #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ja7ad
changed the title
b00f
reviewed
Oct 4, 2024
| @@ -160,7 +160,7 @@ require ( | |||
| github.com/spaolacci/murmur3 v1.1.0 // indirect | |||
| github.com/spf13/cast v1.7.0 // indirect | |||
| github.com/whyrusleeping/go-keyspace v0.0.0-20160322163242-5b898ac5add1 // indirect | |||
| github.com/wlynxg/anet v0.0.4 // indirect | |||
There was a problem hiding this comment.
I can't accept this indirect change. unless we test it properly.
There was a problem hiding this comment.
What you think try next rc in testnet with linux and android?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed build android version pactus-daemon for package anet in go v1.23.2.
Related issue(s)