Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc): add GetAccountByNumber API to get account by number #511

Merged
merged 10 commits into from
Jun 15, 2023
Merged

feat(grpc): add GetAccountByNumber API to get account by number #511

merged 10 commits into from
Jun 15, 2023

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jun 15, 2023

Description

Add RPC method GetAccountByNumber to get account by number

Related issue(s)

Fixed #505

/claim #505

go.mod Show resolved Hide resolved
store/mock.go Outdated Show resolved Hide resolved
store/store.go Outdated Show resolved Hide resolved
www/grpc/blockchain_test.go Outdated Show resolved Hide resolved
www/grpc/blockchain_test.go Outdated Show resolved Hide resolved
www/grpc/server.go Outdated Show resolved Hide resolved
www/grpc/blockchain_test.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jun 15, 2023

@Ja7ad you can use make test or make unit_test locally to make sure all tests are passed.

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Jun 15, 2023

@Ja7ad you can use make test or make unit_test locally to make sure all tests are passed.

done

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #511 (56c364e) into main (1787d9f) will increase coverage by 0.10%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   82.95%   83.05%   +0.10%     
==========================================
  Files         154      154              
  Lines        7305     7313       +8     
==========================================
+ Hits         6060     6074      +14     
+ Misses        961      955       -6     
  Partials      284      284              

@b00f
Copy link
Collaborator

b00f commented Jun 15, 2023

@Ja7ad Thanks

@b00f b00f merged commit f550c79 into pactus-project:main Jun 15, 2023
@Ja7ad Ja7ad deleted the feature/GetAccountByNumber branch June 15, 2023 17:40
@b00f b00f changed the title feat: add GetAccountByNumber API to get account by number feat(grpc): add GetAccountByNumber API to get account by number Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC: Adding new API for GetAccountByNumber
2 participants