Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: License year update #570

Merged
merged 1 commit into from
Jul 4, 2023
Merged

chore: License year update #570

merged 1 commit into from
Jul 4, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jul 4, 2023

Description

just update 2020 to 2023.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #570 (d6d2579) into main (2dd2f3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files         154      154           
  Lines        7249     7249           
=======================================
  Hits         6053     6053           
  Misses        916      916           
  Partials      280      280           

@kehiy kehiy enabled auto-merge (squash) July 4, 2023 20:18
@kehiy kehiy requested review from themantre and amirvalhalla and removed request for themantre July 4, 2023 20:18
Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kehiy thanks

@kehiy kehiy merged commit 2167ca9 into pactus-project:main Jul 4, 2023
@kehiy kehiy deleted the License branch July 4, 2023 21:03
@b00f
Copy link
Collaborator

b00f commented Jul 5, 2023

@kehiy @amirvalhalla

I am going to revert this change. Because, I checked some MIT projects like NodeJS, Angular, curl. Also asked ChatGPT:

In MIT license, what should be the year?

In the MIT License, the year should be the year that the work was published or created. The license is typically included when the software is published, so the year would be when the software was first made available to the public.

What we know that the year should be the year that the project is published. Clearly here is 2020.

Some projects follow this pattern: <Publish year> - <This year>: like 2000 - 2023. I found this post on curl project. However, following this style would also require us to update the license every year, which could be inconvenient.

@amirvalhalla
Copy link
Member

@b00f thanks.

@kehiy kehiy changed the title feat: License year update chore: License year update Jul 5, 2023
@kehiy
Copy link
Contributor Author

kehiy commented Jul 5, 2023

@kehiy @amirvalhalla

I am going to revert this change. Because, I checked some MIT projects like NodeJS, Angular, curl. Also asked ChatGPT:

In MIT license, what should be the year?
In the MIT License, the year should be the year that the work was published or created. The license is typically included when the software is published, so the year would be when the software was first made available to the public.

What we know that the year should be the year that the project is published. Clearly here is 2020.

Some projects follow this pattern: <Publish year> - <This year>: like 2000 - 2023. I found this post on curl project. However, following this style would also require us to update the license every year, which could be inconvenient.

sure, we should follow the best way.

b00f added a commit that referenced this pull request Jul 5, 2023
amirvalhalla pushed a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants