fix: adding committers to the certificate #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 83.55% 83.62% +0.06%
==========================================
Files 154 154
Lines 7274 7267 -7
==========================================
- Hits 6078 6077 -1
+ Misses 914 911 -3
+ Partials 282 279 -3 |
b00f
requested review from
yenkhoon,
vlasfama,
ZigBalthazar,
sadaghiani,
Ja7ad,
kehiy and
amirvalhalla
amirvalhalla
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts #444.
While it may seem optimal to remove the committer list from the certificate, it's not practical for the following reasons:
1- It's logical for a certificate to include the list of its signers (or committers) alongside the signature.
2- Retrieving the committers of a certificate based on the current state of the blockchain isn't feasible without storing additional information.