refactor(sync): refactoring syncing process #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested review from
ZigBalthazar,
amirvalhalla and
kehiy
and removed request for
ZigBalthazar
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 83.70% 83.50% -0.21%
==========================================
Files 167 168 +1
Lines 8009 7922 -87
==========================================
- Hits 6704 6615 -89
- Misses 1002 1004 +2
Partials 303 303 |
kehiy
approved these changes
Sep 5, 2023
amirvalhalla
reviewed
Sep 6, 2023
amirvalhalla
requested changes
Sep 6, 2023
amirvalhalla
approved these changes
Sep 6, 2023
|
@b00f |
|
@amirvalhalla could you please double check it. If anything missed, mention me. |
amirvalhalla
requested changes
Sep 7, 2023
b00f
commented
Sep 7, 2023
themantre
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes these changes:
1-
HeartBeatmessage is removed.2-
HelloAckmessage is added. Once a node receives aHelloAck, it can start sending messages.3-
MaxOpenSessionsis removed and the maximum number of sessions should be the same as the number of connected peers.4- Syncing process is based on time, not height. If the last block time is more than 20 seconds behind the current time, the node starts syncing.