Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Hole Punching to network #697

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 13, 2023

Description

I added the hole punching config for the network.
(After checking the success rate on Prometheus or Grafna we can close the related issue)

Related issue(s)

If this Pull Request is related to an issue, mention it here.
Related #620

@kehiy kehiy requested a review from b00f September 13, 2023 16:54
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #697 (e7b9bf9) into main (1151c64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files         168      168           
  Lines        7982     7983    +1     
=======================================
+ Hits         6663     6664    +1     
  Misses       1015     1015           
  Partials      304      304           

@kehiy kehiy added the network label Sep 13, 2023
config/example_config.toml Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f September 14, 2023 10:33
@kehiy kehiy changed the title feat: Adding Hole Punching to network config feat: Adding Hole Punching to network Sep 14, 2023
@b00f b00f merged commit 019ab6b into pactus-project:main Sep 14, 2023
14 checks passed
@kehiy kehiy deleted the feature/holePunchingLibp2p branch September 14, 2023 12:22
@kehiy kehiy mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants