Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding address field for AccountInfo #703

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 18, 2023

Description

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@kehiy kehiy added www high priority It has high priority labels Sep 18, 2023
@kehiy kehiy requested review from b00f and Ja7ad September 18, 2023 14:28
@kehiy kehiy self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #703 (c40fcfd) into main (0ae9f82) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   83.51%   83.48%   -0.03%     
==========================================
  Files         169      169              
  Lines        7916     7879      -37     
==========================================
- Hits         6611     6578      -33     
+ Misses       1011     1007       -4     
  Partials      294      294              

@b00f
Copy link
Collaborator

b00f commented Sep 18, 2023

@kehiy

Better we remove accountByNumber It is useless now

@kehiy
Copy link
Contributor Author

kehiy commented Sep 18, 2023

@b00f it's done.

store/account.go Show resolved Hide resolved
@kehiy kehiy requested a review from b00f September 18, 2023 17:30
@b00f b00f merged commit cf9b48a into pactus-project:main Sep 19, 2023
12 checks passed
@kehiy kehiy deleted the feature/addressGRPC branch September 19, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority It has high priority www
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding address field for AccountInfo
2 participants