Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing pip-7 #731

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Conversation

amirvalhalla
Copy link
Member

@amirvalhalla amirvalhalla commented Oct 5, 2023

Description

This PR implemented pip-7

Fixed #611

@amirvalhalla amirvalhalla self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #731 (b4e9c04) into main (cbaa43a) will decrease coverage by 0.10%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   83.04%   82.94%   -0.10%     
==========================================
  Files         172      172              
  Lines        8026     8032       +6     
==========================================
- Hits         6665     6662       -3     
- Misses       1044     1051       +7     
- Partials      317      319       +2     

@amirvalhalla amirvalhalla added the enhancement New feature or request label Oct 5, 2023
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirvalhalla Thanks, everything same as pip-7.

sync/bundle/message/hello_test.go Outdated Show resolved Hide resolved
sync/handler_hello.go Outdated Show resolved Hide resolved
sync/handler_hello_test.go Outdated Show resolved Hide resolved
@amirvalhalla amirvalhalla requested a review from b00f October 6, 2023 18:34
sync/bundle/message/hello_test.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Oct 6, 2023

@amirvalhalla Looks good. Just one tests looks extra.

@amirvalhalla amirvalhalla merged commit 76e7568 into pactus-project:main Oct 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants